Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(minor-axelarnet-gateway): simplify the initial implementation #583

Merged
merged 28 commits into from
Aug 29, 2024
Merged

refactor(minor-axelarnet-gateway): simplify the initial implementation #583

merged 28 commits into from
Aug 29, 2024

Conversation

cgorenflo
Copy link
Contributor

@cgorenflo cgorenflo commented Aug 13, 2024 •
edited
Loading

@cgorenflo cgorenflo requested a review from a team as a code owner August 13, 2024 02:50
@cgorenflo cgorenflo marked this pull request as draft August 13, 2024 02:55
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.92188% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.61%. Comparing base (8308c8d) to head (1619e05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ontracts/axelarnet-gateway/src/contract/execute.rs 92.80% 9 Missing ⚠️
contracts/axelarnet-gateway/src/contract.rs 92.30% 2 Missing ⚠️
...ontracts/axelarnet-gateway/src/clients/external.rs 96.87% 1 Missing ⚠️
contracts/axelarnet-gateway/src/state.rs 98.03% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   93.73%   93.61%   -0.13%     
==========================================
  Files         219      219              
  Lines       30988    30545     -443     
==========================================
- Hits        29048    28595     -453     
- Misses       1940     1950      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cjcobb23
cjcobb23 reviewed Aug 13, 2024
View reviewed changes
contracts/axelarnet-gateway/src/state.rs Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/state.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/state.rs Outdated Show resolved Hide resolved
milapsheth
milapsheth reviewed Aug 13, 2024
View reviewed changes
contracts/axelarnet-gateway/src/msg.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/clients/external.rs Outdated Show resolved Hide resolved
@cgorenflo
refactor(axelarnet-gateeway): improve contract structure
d4d6696
@cgorenflo
improve naming
d1a4c6b
@cgorenflo
Merge remote-tracking branch 'refs/remotes/origin/main' into refactor…
3054ae5 
…-axelarnet-gateway

# Conflicts:
#	contracts/axelarnet-gateway/src/clients/external.rs
#	contracts/axelarnet-gateway/src/contract/execute.rs
#	contracts/axelarnet-gateway/src/state.rs
#	contracts/gateway/src/state.rs
@cgorenflo cgorenflo changed the title refactor(axelarnet-gateway-minor): simplify the initial implementation refactor(minor-axelarnet-gateway): simplify the initial implementation Aug 22, 2024
@cgorenflo cgorenflo marked this pull request as ready for review August 23, 2024 04:20
milapsheth
milapsheth reviewed Aug 23, 2024
View reviewed changes
contracts/axelarnet-gateway/src/lib.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/clients/mod.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/state.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/state.rs Outdated Show resolved Hide resolved
packages/axelar-wasm-std/src/error.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/clients/external.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/clients/external.rs Outdated Show resolved Hide resolved
contracts/axelarnet-gateway/src/contract/execute.rs Outdated Show resolved Hide resolved
@cgorenflo
Merge remote-tracking branch 'refs/remotes/origin/main' into refactor…
8ad0661 
…-axelarnet-gateway

# Conflicts:
#	contracts/axelarnet-gateway/src/contract.rs
#	contracts/axelarnet-gateway/src/contract/execute.rs
#	contracts/axelarnet-gateway/src/lib.rs
#	contracts/axelarnet-gateway/src/msg.rs
@cgorenflo
fixes from comments
31d21bb
@cgorenflo
lint
b965022
@cgorenflo cgorenflo merged commit 13390b9 into main Aug 29, 2024
8 checks passed
@cgorenflo cgorenflo deleted the refactor-axelarnet-gateway branch August 29, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 left review comments

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgorenflo @milapsheth @cjcobb23